R4R: Fix fuxi-3000 consensus failure #109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my analysis, I think the main reasons of the consensus failure of fuxi-3000 are as follows:
infractionHeight
is 1 andctx.BlockHeight()
is 0. Then panic error happened.Besides, when a validator is new added and it launchs double sign attack in the first block after it become a real validator. Then the double sign evidence happen to be included by the block proposal, then in the
beginBlock
, we will try to slash a validator which has no sign info. However, the sign info is required for figuring out the jail period. This panic error is just for checking the existence of validator sign info.But this situation is possible and reasonable, we can't just panic, instead we should check the sign info of a validator before slashing it.